[parametric] Enable the W3C Phase 3 test for cpp#2784
Closed
zacharycmontoya wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Note: This is expected to fail until the related PR gets merged. Until then, I will keep this in draft |
84370f6 to
69d3194
Compare
1b567e0 to
068d3af
Compare
Contributor
Author
|
Note: The cpp parametric tests are passing, which indicates this update is successful |
Contributor
|
This PR is blocked by: DataDog/dd-trace-cpp#170. The cpp parametric app does not support the new trace/span/extract_headers endpoint. Currently all parametric tests that generate spans from http headers are skipped. cc: @dmehala |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ensures that our handling of the W3C Trace Context headers is complete and provides the best distributed tracing experience.
Changes
Enables the following test cases for cpp:
tests/parametric/test_headers_tracecontext.py::Test_Headers_Tracecontext::test_tracestate_w3c_p_extract_datadog_w3cDepends on functionality introduced in DataDog/dd-trace-cpp#142
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present