Skip to content

Conversation

@smola
Copy link
Member

@smola smola commented Mar 3, 2025

Motivation

Remove testing sampling rate via RC. This mechanism was never in production. Making it compatible with both old and new API Security algorithms, but without RC.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@smola smola marked this pull request as ready for review March 4, 2025 08:00
@smola smola requested review from a team as code owners March 4, 2025 08:00
@smola smola merged commit ffc1cfb into main Mar 4, 2025
338 checks passed
@smola smola deleted the smola/api-sec-old-rate branch March 4, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants