Skip to content

Update mypy to 2.1.0#7232

Merged
cbeauchesne merged 1 commit into
mainfrom
cbeauchesne/mypy-update
Jun 30, 2026
Merged

Update mypy to 2.1.0#7232
cbeauchesne merged 1 commit into
mainfrom
cbeauchesne/mypy-update

Conversation

@cbeauchesne

Copy link
Copy Markdown
Collaborator

Motivation

mypy fixed a bug on the version we were using : python/mypy#18585

Changes

Per title

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

requirements.txt                                                        @DataDog/system-tests-core
tests/integrations/test_dbm.py                                          @DataDog/system-tests-core
tests/test_config_consistency.py                                        @DataDog/system-tests-core
tests/test_the_test/test_junit.py                                       @DataDog/system-tests-core
utils/_remote_config.py                                                 @DataDog/system-tests-core
utils/manifest/_internal/validate.py                                    @DataDog/system-tests-core

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jun 29, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 4 Pipeline jobs failed

Testing the test | System Tests (php, dev) / End-to-end #1 / apache-mod-7.0 1   View in Datadog   GitHub Actions

🧪 1 Test failed

tests.ffe.test_exposures.Test_FFE_Exposure_Events.test_ffe_multiple_remote_config_files[apache-mod-7.0] from system_tests_suite   View in Datadog
AssertionError: Timed out waiting for exposure event for flags ['test-flag-1', 'test-flag-2'] and subject 'test-user-multi'
assert False
 +  where False = <bound method ProxyBasedInterfaceValidator.wait_for of AgentInterfaceValidator('agent')>(<function wait_for_exposure_event.<locals>.<lambda> at 0x7fed0e5e2de0>, timeout=30)
 +    where <bound method ProxyBasedInterfaceValidator.wait_for of AgentInterfaceValidator('agent')> = AgentInterfaceValidator('agent').wait_for
 +      where AgentInterfaceValidator('agent') = interfaces.agent

self = <tests.ffe.test_exposures.Test_FFE_Exposure_Events object at 0x7fed38607cb0>

    def test_ffe_multiple_remote_config_files(self):
        """Test that FFE correctly handles multiple remote config files with different flags."""
...

Testing the test | System Tests (java, dev) / End-to-end #1 / openai-java@4.29.0 1   View in Datadog   GitHub Actions

Testing the test | System Tests (golang, dev) / parametric / parametric (1)   View in Datadog   GitHub Actions

View all 4 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8ebcfe6 | Docs | Datadog PR Page | Give us feedback!

@cbeauchesne cbeauchesne marked this pull request as ready for review June 30, 2026 06:59
@cbeauchesne cbeauchesne requested a review from a team as a code owner June 30, 2026 06:59
@cbeauchesne cbeauchesne merged commit 773a15e into main Jun 30, 2026
2026 of 2030 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/mypy-update branch June 30, 2026 06:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ebcfe6217

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

# APMAPI-1199: update nodejs to use dd.trace_id instead of trace_id
# APMAPI-1234: update dotnet to use dd.trace_id instead of dd_trace_id
return record.get("dd.trace_id", record.get("trace_id", record.get("dd_trace_id")))
return record.get("dd.trace_id", record.get("trace_id", record.get("dd_trace_id", "")))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve None for missing injected IDs

When a log record lacks all accepted trace-id keys, this now returns "" instead of None, so the log-injection enabled/default-structured checks that assert tid is not None will pass even though the trace ID is missing; the same fallback added for span IDs below similarly hides a missing span ID. Please keep the missing-key result distinguishable from a present ID (or update the assertions to reject empty strings).

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant