Update mypy to 2.1.0#7232
Conversation
|
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ebcfe6217
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # APMAPI-1199: update nodejs to use dd.trace_id instead of trace_id | ||
| # APMAPI-1234: update dotnet to use dd.trace_id instead of dd_trace_id | ||
| return record.get("dd.trace_id", record.get("trace_id", record.get("dd_trace_id"))) | ||
| return record.get("dd.trace_id", record.get("trace_id", record.get("dd_trace_id", ""))) |
There was a problem hiding this comment.
Preserve None for missing injected IDs
When a log record lacks all accepted trace-id keys, this now returns "" instead of None, so the log-injection enabled/default-structured checks that assert tid is not None will pass even though the trace ID is missing; the same fallback added for span IDs below similarly hides a missing span ID. Please keep the missing-key result distinguishable from a present ID (or update the assertions to reject empty strings).
Useful? React with 👍 / 👎.
Motivation
mypy fixed a bug on the version we were using : python/mypy#18585
Changes
Per title
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present