Derive PARAMETER_SOURCE_MAP waterlevels list from the registry (3.3)#105
Merged
Conversation
…y (3.3) The waterlevels agency list duplicated what the registry already encodes — the sources with a waterlevel class. It is now derived (`[s.key for s in SOURCES if s.waterlevel]`); PARAMETER_SOURCE_MAP moved below the registry so it can reference SOURCES. Analyte entries stay authored (they encode which analytes each agency reports, not inferable from class wiring). Derived list is identical (incl. order) to the previous hardcoded one; the test_source_registry consistency test still guards the relationship. Full suite (311) + dg check defs clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Your pull request is automatically being deployed to Dagster Cloud.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tier 3 item 3.3 from
docs/cleanup-todo.md. Stacked on #104 (basechore/cleanup-tier2). Merge order: #101 → #102 → #103 → #104 → this.The
WATERLEVELSentry ofPARAMETER_SOURCE_MAPduplicated what theSOURCESregistry already encodes — the sources with a waterlevel class. It's now derived:PARAMETER_SOURCE_MAPmoved below the registry so it can referenceSOURCES. Analyte entries stay authored — they encode which analytes each agency actually reports, which can't be inferred from class wiring.The derived list is identical (including order) to the previous hardcoded one;
tests/test_source_registry.pystill guards the registry↔map relationship.No behavior change. Full suite 311 passed;
dg check defsclean.🤖 Generated with Claude Code