Skip to content

Coerce MCL exceedance value to float before comparison #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jirhiker merged 1 commit into from
Jun 30, 2026
Merged

Coerce MCL exceedance value to float before comparison #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend/persisters/ogc_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,8 @@ def dump_mcl_exceedance_collection(
# larger). If the data basis is NO3, this flag is wrong unless the
# mcl in config/mcl.json is the as-NO3 value (~44.3 mg/L). Confirm
# DIE's normalized nitrate basis before trusting nitrate exceedances.
exceeds = value is not None and mcl is not None and value > mcl
num = _num(value)
exceeds = num is not None and mcl is not None and num > mcl
props[f"{analyte}_exceeds"] = exceeds
if exceeds:
exceeded.append(analyte)
Expand Down
Loading