Fix Dagster+ PEX deploy: nmuwd path trailing slash#72
Merged
Conversation
The serverless PEX build failed parsing '..' as a dependency: Problem parsing '..' as a requirement: Expected package name The dagster-cloud PEX builder resolves [tool.uv.sources] path deps to a local package only when the path starts with "./", "../", or "/". Bare ".." falls through to the dependency resolver and crashes. Use "../" so nmuwd is bundled into the source PEX as intended. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Your pull request is automatically being deployed to Dagster Cloud.
|
dagster-cloud-deploy.yml / dagster-cloud-branch-deployments.yml duplicate the official quickstart workflows (deploy.yml / branch_deployments.yml): same concurrency groups and job names, so the two pairs cancelled each other and double-ran. Keep the official pair (DAGSTER_CLOUD_URL set, pinned actions); drop the redundant pair. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The serverless PEX build asserts the deps pex contains dagster_cloud: ValueError: The dagster_cloud package dependency was expected but not found. It was missing from orchestration/pyproject.toml; add it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploy synced but the location failed to import: ModuleNotFoundError: No module named 'orchestration' The source PEX copies build.directory contents into an importable working_directory/root. With directory: orchestration, that root held orchestration's *contents* flat, so there was no `orchestration` package and `orchestration.definitions` (plus its `from backend...` imports) couldn't resolve. Build from the repo root instead: working_directory/root now contains orchestration/ and backend/ as top-level packages. Runtime deps move to a root requirements.txt (dagster stack), since the root pyproject is the nmuwd package and doesn't carry them. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dagster+ serverless PEX deploy failed resolving dependencies:
Cause:
orchestration/pyproject.tomldeclares[tool.uv.sources] nmuwd = { path = ".." }. The dagster-cloud PEX builder only treats a uv.sources path as a local package (bundled into the source PEX) when it starts with./,../, or/. Bare..slips past that check and is handed to the dependency resolver, which crashes.Fix:
path = "../"(trailing slash) → recognized as the local repo-root package, as intended.uv lockstill resolves cleanly.This branch-deployment run exercises the PEX build with the configured secrets, so a green "Dagster Serverless Deploy" check here confirms the fix before it reaches the prod deploy on
main.🤖 Generated with Claude Code