Remove redundant nm_tds_latest product#74
Merged
Merged
Conversation
nm_tds_latest was ogc_summary over the same tds parameter/filter/sources as nm_tds_summary — identical GeoJSON, just a different id. The summary output already carries latest_value/latest_date per site, so the latest value is one field of nm_tds_summary, not a separate product. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Your pull request is automatically being deployed to Dagster Cloud.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #73.
nm_tds_latestwasogc_summaryover the sametdsparameter / filter / sources asnm_tds_summary— identical GeoJSON, just a different id, running the full unify twice.The summary output already carries
latest_value/latest_dateper site, so the latest TDS value is a field ofnm_tds_summary, not a separate product. Removing it.If raw per-observation TDS is wanted later, add
nm_tds_timeseries(ogc_timeseries) — that's the non-redundant counterpart.🤖 Generated with Claude Code