Scope bernco product statewide to dedupe its source fetch#94
Merged
Conversation
The bernco source is county-scoped by construction (all wells in Bernalillo), so the county_Bernalillo filter was a no-op. Switching the bernco product to state_NM scope (keeping include:[bernco]) yields identical output but lets it share the statewide bernco source asset instead of unifying bernco a second time under its own scope. Removes the singleton Bernalillo cohort: bernco_waterlevels_timeseries now joins the waterlevels_timeseries_state_NM cohort. Source assets 87 -> 86, cohort jobs 5 -> 4. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Your pull request is automatically being deployed to Dagster Cloud.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the cohort-jobs change (#93). The bernco source (
BernCoWaterLevelSource) is county-scoped by construction — all its wells are in Bernalillo — so thecounty_Bernalillofilter onbernco_waterlevels_timeserieswas a no-op.Switching that product to
state_NMscope (keepinginclude: [bernco]) yields identical output but lets it share the statewide bernco source asset instead of unifying bernco a second time under its own scope.Effect:
bernco_waterlevels_timeseriesjoins thewaterlevels_timeseries_state_NMcohort; cohort jobs 5 → 4.Caveat: the county filter was a cheap guard against a stray out-of-county well; removing it trusts the source's construction (low risk — it's county-scoped).
dg check defsclean; 277 offline tests pass.🤖 Generated with Claude Code