BDMS 57: well screen & other updates#121
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
|
ksmuczynski
approved these changes
Sep 4, 2025
ksmuczynski
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me.
jirhiker
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
WellScreenshould havenma_pk_wellscreensto enable an audit of the data transfermapped_column(...)How
Implementation summary - the following was changed / added / removed:
nma_pk_wellscreenstoWellScreentable to enable transfer auditsnullable=Trueornullable=Falseinmapped_column(...)nma_pk_wellscreensare not part of the Pydantic model/schema well screens are now added explicitly with the session instead of withmodel_adderNotes
Any special considerations, workarounds, or follow-up work to note?
Mapped[<type?>]is what SQL Alchemy uses. It does not need to be set inmapped_column(...). To set the string length, however,String(<length>)must be used inmapped_column(...).