Skip to content

BDMS-220#226

Merged
jirhiker merged 2 commits into
stagingfrom
BDMS-220-Implement-feature-in-Thing-API-for-BDMS-218
Nov 4, 2025
Merged

BDMS-220#226
jirhiker merged 2 commits into
stagingfrom
BDMS-220-Implement-feature-in-Thing-API-for-BDMS-218

Conversation

@jirhiker

@jirhiker jirhiker commented Nov 4, 2025

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • Use path parameters to get Thing so that we can use thing specific responses e.g. WellResponse. (seems like this still could be done with query parameters tho?)

How

Implementation summary - the following was changed / added / removed:

  • Use bullet points here

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

@jirhiker jirhiker changed the title fix: add thing_type parameter to function in thing.py for enhanced query capabilities BDMS-220: add thing_type parameter to function in thing.py for enhanced query capabilities Nov 4, 2025
@codecov-commenter

codecov-commenter commented Nov 4, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.
see 4 files with indirect coverage changes

@jacob-a-brown jacob-a-brown left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to maintain this query parameter would you add a test to tests/test_thing.py to maintain coverage? Also, should there be a test per thing type that we have defined? Currently I think we only have water well and spring

@jirhiker jirhiker changed the title BDMS-220: add thing_type parameter to function in thing.py for enhanced query capabilities BDMS-220 Nov 4, 2025
@jirhiker jirhiker merged commit ce847fa into staging Nov 4, 2025
6 checks passed
@jirhiker jirhiker deleted the BDMS-220-Implement-feature-in-Thing-API-for-BDMS-218 branch December 3, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants