BDMS-463: Docker Compose Update#384
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Docker networking issue where the app container was missing an explicit POSTGRES_PORT environment variable, causing it to potentially use the wrong port when connecting to the database container.
Changes:
- Set
POSTGRES_PORT=5432in theappservice environment to ensure correct container-to-container database connections - Restructured README.md to clarify the two development workflow options (local PostgreSQL vs Docker Compose)
- Added documentation about port mapping (
5432internal,54321external) and when to use each
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker-compose.yml | Added POSTGRES_PORT=5432 environment variable to the app service to fix database connection |
| README.md | Reorganized and clarified development setup options, replacing table layout with clearer sections and adding notes about port configuration |
jirhiker
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
POSTGRES_PORT, so it could read the host.envvalue (54321) or a non-container default. If it uses54321inside Docker, db connection will fail because the database is only listening on5432within the Docker network.How
Implementation summary - the following was changed / added / removed:
POSTGRES_PORT=5432to theappservice environment indocker-compose.ymlto ensure container-to-container connections use the internal DB portNotes
Any special considerations, workarounds, or follow-up work to note?
dbservice still maps54321:5432; local tools and commands should usePOSTGRES_PORT=54321to communicate to thedbservice, like setup with the.env.example