BDMS-441: Admin view features for legacy nma#387
Closed
chasetmartin wants to merge 3 commits into
Closed
Conversation
chasetmartin
requested review from
Copilot,
jirhiker,
kbighorse and
ksmuczynski
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive BDD test coverage for legacy NMA (New Mexico Aquifer) admin views to validate list views consistently across the application's admin interface.
Changes:
- Created 11 new Cucumber feature files for admin views of legacy NMA database tables
- Each feature follows a consistent pattern with authentication, navigation, and column verification scenarios
- Added seed data definitions for test scenarios across all legacy NMA data types
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| features/admin/nma_hydraulics_data_admin.feature | Tests admin list view for hydraulics test data with columns for well properties and transmissivity |
| features/admin/nma_radionuclides_admin.feature | Tests admin list view for radionuclide sample analysis data |
| features/admin/nma_surface_water_admin.feature | Tests admin list view for surface water discharge measurements |
| features/admin/nma_weather_data_admin.feature | Tests admin list view for weather station observations |
| features/admin/nma_water_levels_continuous_pressure_daily_admin.feature | Tests admin list view for daily continuous pressure water level readings |
| features/admin/nma_ngwmn_well_construction_admin.feature | Tests admin list view for NGWMN well construction details including casing and screen information |
| features/admin/nma_ngwmn_water_levels_admin.feature | Tests admin list view for NGWMN water level measurements |
| features/admin/nma_ngwmn_lithology_admin.feature | Tests admin list view for NGWMN lithological layer data |
| features/admin/nma_major_chemistry_admin.feature | Tests admin list view for major ion chemistry analysis results |
| features/admin/nma_chemistry_sampleinfo_admin.feature | Tests admin list view for chemistry sample collection metadata |
| features/admin/nma_chemistry_minor_trace_admin.feature | Tests admin list view for minor and trace element chemistry data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
db/nma_legacy.pyso list views are validated consistently with existing chemistry admin features.How
NMA_HydraulicsData,NMA_Radionuclides,NMA_SurfaceWaterData,NMA_WeatherData,NMA_WaterLevelsContinuous_Pressure_Daily,NMA_view_NGWMN_WellConstruction,NMA_view_NGWMN_WaterLevels,NMA_view_NGWMN_Lithology, andNMA_MajorChemistry, each with seed data, admin path, and expected columns.Notes