Test database connection should not be overridden by .env#411
Merged
Conversation
Change load_dotenv(override=False) so test framework's environment settings (e.g., POSTGRES_DB=ocotilloapi_test) are not overwritten by .env file values. Previously, tests would connect to the dev database instead of the test database because load_dotenv(override=True) replaced the test framework's POSTGRES_DB setting. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a test isolation issue where test database connections were being incorrectly overridden by development environment variables. The change ensures that environment variables set by the test framework (specifically POSTGRES_DB=ocotilloapi_test) are preserved and not replaced by values from the .env file.
Changes:
- Modified
load_dotenv()call to useoverride=Falseinstead ofoverride=Truein database engine initialization - Updated accompanying comment to reflect the new behavior regarding environment variable precedence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_dotenv(override=True)→load_dotenv(override=False)indb/engine.pyPOSTGRES_DB=ocotilloapi_testfrom being overwritten by.envvaluesFixes #412
Problem
Tests were connecting to the dev database instead of the test database because
load_dotenv(override=True)replaced the environment variables set by the test framework intests/__init__.py.Test plan
ocotilloapi_testdatabase🤖 Generated with Claude Code