BDMS-484-485-486-487-490-SampleInfo-MajorMinorChem-Refactor-Features

[chasetmartin]

Why

This PR addresses the following problem / context:

• Add BDD features for refactoring 5 legacy chemistry data tables into the Ocotillo schema(SampleInfo, MajorChemistry, Minor/TraceChemistry, FieldParameters, Radionuclides)
• Documents expected mappings and behavior (idempotent backfill, linkage, notes).

How

Implementation summary - the following was changed / added / removed:

• Add new feature files that define backfill/refactor behavior for chemistry sample info, major chemistry observations, and minor/trace chemistry observations
• Specify field-to-model expectations (Observation, Sample, Parameter, Notes) including agency, analysis method/date, uncertainty, volume/unit, and detect flags
• Include skip/orphan prevention scenarios and unmapped-field exclusions for legacy data

Notes

Any special considerations, workarounds, or follow-up work to note?

• Features will likely require db model changes to add specific fields that do not exist yet.

[Copilot]

Pull request overview

This PR adds BDD feature files to document the expected behavior for refactoring three legacy chemistry data tables (SampleInfo, MajorChemistry, MinorTraceChemistry) into the Ocotillo schema. The features specify field mappings, linkage requirements, idempotency guarantees, and handling of unmapped legacy fields.

Changes:

• Added feature files defining backfill behavior for chemistry sample metadata and major/minor chemistry observations
• Specified field-to-model mappings including agency, analysis methods, uncertainty, volume/unit, and detection flags
• Included scenarios for orphan prevention, data provenance, notes linkage, and public release controls

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
tests/features/nma_chemistry-sampleinfo-refactor.feature	Defines backfill scenarios for migrating legacy Chemistry_SampleInfo to Sample records with provenance, notes, and quality controls
tests/features/nma-chemistry-minortracechemistry-refactor.feature	Specifies migration behavior for minor/trace chemistry results to Observation records with parameter linkage and detection qualifiers
tests/features/nma-chemistry-majorchemistry-refactor.feature	Defines migration scenarios for major chemistry results to Observation records with similar patterns to minor/trace chemistry

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.