bugfix: increase length of LithologicModifier field to accommodate larger values#429
Conversation
There was a problem hiding this comment.
Pull request overview
This PR increases the maximum length of the LithologicModifier field from 100 to 250 characters to accommodate larger values in the NMA stratigraphy data model.
Changes:
- Updated the
LithologicModifierfield length constraint fromString(100)toString(250)in both the SQLAlchemy model and the Alembic migration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| db/nma_legacy.py | Updated the lithologic_modifier field's String type length from 100 to 250 in the NMA_Stratigraphy model |
| alembic/versions/1d2c3b4a5e67_create_nma_stratigraphy_table.py | Updated the LithologicModifier column definition to use String(250) instead of String(100) in the table creation migration |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ead4baf874
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…rt and update return type
jirhiker
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
chasetmartin
left a comment
chasetmartin
left a comment
There was a problem hiding this comment.
Nice, looking forward to trying this in the transfer
We should continue updating an AGENTS.MD as needed, good to add it.
Why
transfer was failing to transfer NMA_Stratigraphy because of inaccurate ORM/alembic definition
CRITI [transfers.logger] Parallel task StratigraphyLegacy failed: (pg8000.exceptions.DatabaseError) {'S': 'ERROR', 'V': 'ERROR', 'C': '22001', 'M': 'value too long for type character varying(100)', 'F': 'varchar.c', 'L': '640', 'R': 'varchar'}