Skip to content

BDMS-512: AOUIWL Well Intel Equipment information to be preserved during the migration#435

Merged
jirhiker merged 5 commits into
stagingfrom
BDMS-512-AOUIWL-Well-Intel-Equipment-information-to-be-preserved-during-the-migration
Jan 29, 2026
Merged

BDMS-512: AOUIWL Well Intel Equipment information to be preserved during the migration#435
jirhiker merged 5 commits into
stagingfrom
BDMS-512-AOUIWL-Well-Intel-Equipment-information-to-be-preserved-during-the-migration

Conversation

@jirhiker

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • Use bullet points here

How

Implementation summary - the following was changed / added / removed:

  • Use bullet points here

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

Copilot AI review requested due to automatic review settings January 27, 2026 23:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds legacy equipment fields to the deployment schema to support migration of historical WI (Water Instrument) configuration data from a legacy system.

Changes:

  • Added six new nullable integer fields to the Deployment model with an "nma_WI_" prefix
  • Created a database migration to add these columns to the deployment table
  • Updated sensor transfer logic to populate these fields from source data

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
db/deployment.py Added six new WI-prefixed fields to the Deployment model
alembic/versions/263109252fb1_add_legacy_equipment_fields.py Database migration script to add the new columns to the deployment table
transfers/sensor_transfer.py Updated data transfer logic to populate the new legacy equipment fields

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc8632d150

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread transfers/sensor_transfer.py Outdated
Copilot AI review requested due to automatic review settings January 27, 2026 23:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@jirhiker jirhiker changed the title feat: add legacy equipment fields to deployment schema BDMS-512: AOUIWL Well Intel Equipment information to be preserved during the migration Jan 27, 2026

@chasetmartin chasetmartin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just update the alembic migration to revise the now current staging head (I think 3a9c1f5b7d2e)

After that you should merge in and trigger a transfer during your AUS day. Otherwise I'll do this tomorrow.

@jirhiker jirhiker merged commit a79f46b into staging Jan 29, 2026
6 checks passed
@TylerAdamMartinez TylerAdamMartinez deleted the BDMS-512-AOUIWL-Well-Intel-Equipment-information-to-be-preserved-during-the-migration branch February 5, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants