BDMS-512: AOUIWL Well Intel Equipment information to be preserved during the migration#435
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds legacy equipment fields to the deployment schema to support migration of historical WI (Water Instrument) configuration data from a legacy system.
Changes:
- Added six new nullable integer fields to the Deployment model with an "nma_WI_" prefix
- Created a database migration to add these columns to the deployment table
- Updated sensor transfer logic to populate these fields from source data
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| db/deployment.py | Added six new WI-prefixed fields to the Deployment model |
| alembic/versions/263109252fb1_add_legacy_equipment_fields.py | Database migration script to add the new columns to the deployment table |
| transfers/sensor_transfer.py | Updated data transfer logic to populate the new legacy equipment fields |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc8632d150
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
chasetmartin
left a comment
There was a problem hiding this comment.
Can you just update the alembic migration to revise the now current staging head (I think 3a9c1f5b7d2e)
After that you should merge in and trigger a transfer during your AUS day. Otherwise I'll do this tomorrow.
…rmation-to-be-preserved-during-the-migration
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?