Skip to content

feat: preserve OwnerComment during migration as a note about the contact#436

Merged
chasetmartin merged 5 commits into
stagingfrom
BDMS-511-AOUIWL-OwnersData.OwnerComment-to-be-preserved-during-the-migration-as-a-note-about-the-Contact
Jan 29, 2026
Merged

feat: preserve OwnerComment during migration as a note about the contact#436
chasetmartin merged 5 commits into
stagingfrom
BDMS-511-AOUIWL-OwnersData.OwnerComment-to-be-preserved-during-the-migration-as-a-note-about-the-Contact

Conversation

@jirhiker

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • Use bullet points here

How

Implementation summary - the following was changed / added / removed:

  • Use bullet points here

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds functionality to preserve the legacy OwnerComment field during contact migration by storing it as a note associated with the first contact.

Changes:

  • Added logic to create a note from OwnerComment when migrating the first contact
  • Refactored _add_first_contact and _add_second_contact to return contact objects and accept pre-computed organization
  • Added type hints to helper functions for improved type safety
  • Added "OwnerComment" as a new note type in the lexicon

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
transfers/contact_transfer.py Modified contact transfer logic to capture OwnerComment as a note on the first contact; refactored functions to return contacts and accept organization parameter; added type hints
core/lexicon.json Added "OwnerComment" note type definition to support storing legacy owner comments

Comment thread transfers/contact_transfer.py Outdated
Comment thread transfers/contact_transfer.py
Comment thread transfers/contact_transfer.py Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 080a9c7d0b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread transfers/contact_transfer.py Outdated
Copilot AI review requested due to automatic review settings January 28, 2026 01:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comment thread transfers/contact_transfer.py Outdated
Comment thread transfers/contact_transfer.py Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 28, 2026 01:52
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comment on lines +107 to +109
if (
tag == "first"
and contact

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note creation logic for OwnerComment lacks test coverage for error handling. Consider adding a test case that verifies behavior when contact.add_note() raises an exception.

Copilot uses AI. Check for mistakes.

@chasetmartin chasetmartin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chasetmartin chasetmartin merged commit 9c05f89 into staging Jan 29, 2026
6 checks passed
@TylerAdamMartinez TylerAdamMartinez deleted the BDMS-511-AOUIWL-OwnersData.OwnerComment-to-be-preserved-during-the-migration-as-a-note-about-the-Contact branch February 5, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants