Skip to content

BDMS-491: Implement read-only admin view for NMAHydraulicsData#443

Merged
jirhiker merged 3 commits into
stagingfrom
kas-bdms-491-admin-view-HydraulicsData
Jan 30, 2026
Merged

BDMS-491: Implement read-only admin view for NMAHydraulicsData#443
jirhiker merged 3 commits into
stagingfrom
kas-bdms-491-admin-view-HydraulicsData

Conversation

@ksmuczynski

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem / context:

  • Align HydraulicsData admin UI with the legacy model.

How

Implementation summary - the following was changed / added / removed:

  • Expanded and reordered list, sortable, and searchable fields in admin/views/hydraulicsdata.py to match legacy HydraulicsData.
  • Updated field labels for clearer display names (spacing/units).
  • Switched can_create, can_edit, can_delete to request-aware methods and added the Request import.
  • Minor formatting cleanup.

Notes

Any special considerations, workarounds, or follow-up work to note?

  • No tests added

ksmuczynski and others added 3 commits January 29, 2026 15:46
- Include all HydraulicsData columns in list and detail views
- Order fields to match the legacy model definition

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a read-only admin view for NMAHydraulicsData by aligning the admin interface with the legacy HydraulicsData model. It expands field visibility and improves field labeling for better usability.

Changes:

  • Converted static permission flags to request-aware methods for can_create, can_edit, and can_delete
  • Extended list, sortable, and searchable field lists to include all hydraulics data fields from the legacy model
  • Updated field label for "sy_decimalfractn" to improve readability

@jirhiker jirhiker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jirhiker jirhiker merged commit 717435b into staging Jan 30, 2026
6 checks passed
@TylerAdamMartinez TylerAdamMartinez deleted the kas-bdms-491-admin-view-HydraulicsData branch February 5, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants