BDMS-520-1-1-Cleanup-2.0#444
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances data quality tracking and handles legacy equipment field type corrections in the database migration and transfer logic.
Changes:
- Added
nma_data_qualityfield to observations to capture legacy WaterLevels DataQuality codes - Corrected
nma_WI_MicGainfield type from Integer to Boolean in deployment schema - Improved timezone handling for WaterLevels transfers to respect TimeDatum field
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| transfers/waterlevels_transfer.py | Added DataQuality mapping logic and TimeDatum-aware UTC conversion |
| transfers/sensor_transfer.py | Added boolean coercion helper for WI_MicGain field |
| tests/test_transfer_legacy_dates.py | Added test coverage for DataQuality mapping and TimeDatum handling |
| tests/test_sensor_transfer.py | Added test coverage for WI_MicGain boolean coercion |
| schemas/observation.py | Added nma_data_quality field to observation response schema |
| db/observation.py | Added nma_data_quality column to Observation model |
| db/deployment.py | Changed nma_WI_MicGain type from Integer to Boolean |
| core/lexicon.json | Updated data_quality term definitions to be more descriptive |
| alembic/versions/e123456789ab_add_observation_data_quality.py | Migration to add nma_data_quality column |
| alembic/versions/263109252fb1_add_legacy_equipment_fields.py | Updated migration to use Boolean type for WI_MicGain |
| f"{SPACE_6}Unknown DataQuality code '{dq_code}' for WaterLevels record {row.GlobalID}" | ||
| ) | ||
|
|
||
| # TODO: after sensors have been added to the database update sensor_id (or sensor) for waterlevels that come from db sensors (like e probes?) |
There was a problem hiding this comment.
Corrected spelling of 'db' to 'DB' for consistency with standard database abbreviation conventions.
Suggested change
| # TODO: after sensors have been added to the database update sensor_id (or sensor) for waterlevels that come from db sensors (like e probes?) | |
| # TODO: after sensors have been added to the database update sensor_id (or sensor) for waterlevels that come from DB sensors (like e probes?) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4739aa4279
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?