Skip to content

refactor: split compare engine #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgidhristov merged 2 commits into from
May 12, 2026
Merged

refactor: split compare engine #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41a858e
refactor: split compare renderer and engine
georgidhristov May 12, 2026
247ae5b
cleanup: remove temporary compare debugging logs
georgidhristov May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions DebugProbe.AspNetCore/DebugProbe.AspNetCore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,21 @@
<ItemGroup>
<EmbeddedResource Include="Resources\**\*.html" />
<EmbeddedResource Include="Resources\**\*.css" />
<EmbeddedResource Include="Resources\js\debugprobe-compare.js" />
<EmbeddedResource Include="Resources\js\debugprobe-ui.js" />
<EmbeddedResource Include="Resources\js\debugprobe_compare_engine.js" />
<EmbeddedResource Include="Resources\js\debugprobe_compare_renderer.js" />
<EmbeddedResource Include="Resources\js\debugprobe_ui.js" />
<EmbeddedResource Include="Assets\logo-full.PNG" />
<EmbeddedResource Include="Assets\favicon.ico" />
</ItemGroup>

<ItemGroup>
<None Remove="Resources\**\*.html" />
<None Remove="Resources\**\*.css" />
<None Remove="Resources\js\debugprobe-compare.js" />
<None Remove="Resources\js\debugprobe-ui.js" />
</ItemGroup>

<ItemGroup>
<None Remove="Resources\js\debugprobe_compare_engine.js" />
<None Remove="Resources\js\debugprobe_compare_renderer.js" />
</ItemGroup>

<ItemGroup>
Expand Down
15 changes: 9 additions & 6 deletions DebugProbe.AspNetCore/Extensions/DebugProbeExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,16 @@ public static IApplicationBuilder UseDebugProbe(this IApplicationBuilder app)
return item is null ? Results.NotFound() : Results.Json(item);
}).ExcludeFromDescription();

webApp.MapGet("/debug/compare.js", () =>
Results.Text(EmbeddedResources.CompareJs, "application/javascript")
).ExcludeFromDescription();

webApp.MapGet("/debug/ui.js", () =>
Results.Text(EmbeddedResources.UiJs, "application/javascript")
).ExcludeFromDescription();
webApp.MapGet("/debug/js/{file}", (string file) =>
{
if (!EmbeddedResources.JavaScript.TryGetValue(file, out var content))
{
return Results.NotFound();
}

return Results.Text(content, "application/javascript");
}).ExcludeFromDescription();

webApp.MapPost("/debug/clear", (DebugEntryStore store) =>
{
Expand Down
14 changes: 12 additions & 2 deletions DebugProbe.AspNetCore/Internal/EmbeddedResources.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,20 @@
internal static class EmbeddedResources
{
public static readonly string Css = ResourceLoader.LoadCss("debugprobe.css");

public static readonly string Layout = ResourceLoader.LoadHtml("_shared.layout.html");

public static readonly string Index = ResourceLoader.LoadHtml("index.html");

public static readonly string Details = ResourceLoader.LoadHtml("details.html");
public static readonly string CompareJs = ResourceLoader.LoadJs("debugprobe-compare.js");
public static readonly string UiJs = ResourceLoader.LoadJs("debugprobe-ui.js");

public static readonly Dictionary<string, string> JavaScript = new()
{
["debugprobe-compare-renderer.js"] = ResourceLoader.LoadJs("debugprobe_compare_renderer.js"),

["debugprobe-compare-engine.js"] = ResourceLoader.LoadJs("debugprobe_compare_engine.js"),

["debugprobe-ui.js"] = ResourceLoader.LoadJs("debugprobe_ui.js")
};
}

5 changes: 3 additions & 2 deletions DebugProbe.AspNetCore/Resources/html/_shared/layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

{{content}}

<script src="/debug/ui.js"></script>
<script src="/debug/compare.js"></script>
<script src="/debug/js/debugprobe-ui.js"></script>
<script src="/debug/js/debugprobe-compare-engine.js"></script>
<script src="/debug/js/debugprobe-compare-renderer.js"></script>
</body>
Loading