Skip to content

fix: fix missing request persistence on unhandled exceptions #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgidhristov merged 1 commit into from
May 9, 2026
Merged

fix: fix missing request persistence on unhandled exceptions #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 48 additions & 41 deletions DebugProbe.AspNetCore/Middleware/DebugProbeMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,60 +44,67 @@ public async Task Invoke(HttpContext context, DebugEntryStore store)

var started = Stopwatch.StartNew();

await _next(context);
try
{
await _next(context);
}
finally
{
started.Stop();

started.Stop();
ms.Position = 0;
var responseBody = await new StreamReader(ms).ReadToEndAsync();
ms.Position = 0;
await ms.CopyToAsync(originalBody);

ms.Position = 0;
var responseBody = await new StreamReader(ms).ReadToEndAsync();
ms.Position = 0;
await ms.CopyToAsync(originalBody);
context.Response.Body = originalBody;

var shortDatePattern = CultureInfo.CurrentCulture.DateTimeFormat.ShortDatePattern;
var index = shortDatePattern.LastIndexOf('y');
var dataFormat = index >= 0 ? shortDatePattern[..(index + 1)] : shortDatePattern;
var shortDatePattern = CultureInfo.CurrentCulture.DateTimeFormat.ShortDatePattern;
var index = shortDatePattern.LastIndexOf('y');
var dataFormat = index >= 0 ? shortDatePattern[..(index + 1)] : shortDatePattern;

store.Add(new DebugEntry
{
Id = Guid.NewGuid().ToString(),
store.Add(new DebugEntry
{
Id = Guid.NewGuid().ToString(),

// Environment
Environment = EnvironmentUtils.TryGetEnvironment(),
MachineName = Environment.MachineName,
AssemblyVersion = Assembly.GetEntryAssembly()?.GetName().Version?.ToString(),
TimeZone = TimeZoneInfo.Local.DisplayName,
Culture = CultureInfo.CurrentCulture.Name,
DecimalSeparator = CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator,
DateFormat = dataFormat,
// Environment
Environment = EnvironmentUtils.TryGetEnvironment(),
MachineName = Environment.MachineName,
AssemblyVersion = Assembly.GetEntryAssembly()?.GetName().Version?.ToString(),
TimeZone = TimeZoneInfo.Local.DisplayName,
Culture = CultureInfo.CurrentCulture.Name,
DecimalSeparator = CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator,
DateFormat = dataFormat,

// Overview
Method = context.Request.Method,
Path = context.Request.Path,
Query = context.Request.QueryString.ToString(),
StatusCode = context.Response.StatusCode,
RequestTimeUtc = DateTime.UtcNow,
DurationMs = started.ElapsedMilliseconds,
RequestSize = Encoding.UTF8.GetByteCount(requestBody),
ResponseSize = Encoding.UTF8.GetByteCount(responseBody),
// Overview
Method = context.Request.Method,
Path = context.Request.Path,
Query = context.Request.QueryString.ToString(),
StatusCode = context.Response.StatusCode,
RequestTimeUtc = DateTime.UtcNow,
DurationMs = started.ElapsedMilliseconds,
RequestSize = Encoding.UTF8.GetByteCount(requestBody),
ResponseSize = Encoding.UTF8.GetByteCount(responseBody),

// Request
RequestUrl = $"{context.Request.Scheme}://{context.Request.Host}" +
$"{context.Request.Path}{context.Request.QueryString}",
RequestBody = Trim(requestBody),
// Request
RequestUrl = $"{context.Request.Scheme}://{context.Request.Host}" +
$"{context.Request.Path}{context.Request.QueryString}",
RequestBody = Trim(requestBody),


// Response
ResponseBody = Trim(responseBody),
// Response
ResponseBody = Trim(responseBody),


// Headers
Headers = context.Request.Headers.ToDictionary(x => x.Key, x => x.Value.ToString()),
// Headers
Headers = context.Request.Headers.ToDictionary(x => x.Key, x => x.Value.ToString()),


// Other
Timestamp = DateTime.UtcNow,

});
// Other
Timestamp = DateTime.UtcNow,

});
}
}

private string Trim(string value, int max = 2000)
Expand Down