Skip to content

feat: properly interpret forbidden error codes #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-aleksander merged 3 commits into from
Jun 12, 2024
Merged

feat: properly interpret forbidden error codes #63

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d061f06
add permission denied error type
t-aleksander Jun 6, 2024
ee623f9
Merge branch 'dev' into add-user-disable
t-aleksander Jun 6, 2024
044638c
change error text message
t-aleksander Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ pub enum ApiError {
CoreTimeout,
#[error("Invalid core gRPC response type received")]
InvalidResponseType,
#[error("Permission denied")]
PermissionDenied,
}

impl IntoResponse for ApiError {
Expand All @@ -30,6 +32,7 @@ impl IntoResponse for ApiError {
let (status, error_message) = match self {
Self::Unauthorized => (StatusCode::UNAUTHORIZED, self.to_string()),
Self::BadRequest(msg) => (StatusCode::BAD_REQUEST, msg),
Self::PermissionDenied => (StatusCode::FORBIDDEN, self.to_string()),
_ => (
StatusCode::INTERNAL_SERVER_ERROR,
"Internal server error".to_string(),
Expand All @@ -51,6 +54,7 @@ impl From<CoreError> for ApiError {
match status.code() {
Code::Unauthenticated => ApiError::Unauthorized,
Code::InvalidArgument => ApiError::BadRequest(status.message().to_string()),
Code::PermissionDenied => ApiError::PermissionDenied,
_ => ApiError::Unexpected(status.to_string()),
}
}
Expand Down