WIP: track mitigated status better in reimport#12258
Closed
valentijnscholten wants to merge 3 commits into
Closed
Conversation
8d80f5e to
fa88629
Compare
Member
Author
|
The unit tests are failing because in a single reimport first an existing active inding gets mitigated but later that same existing finding gets matched against another finding in the reimport and gets reactivated again. This make the finding part of both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP alternative to #12249
possibly
self.mitigate_findingshould be used instead of setting the mitigation related fields manually.