metrics: use mitigated_date for closed findings#13945
Merged
rossops merged 1 commit intoDec 22, 2025
Merged
Conversation
valentijnscholten
requested review from
Maffooch and
mtesauro
as code owners
🔴 Risk threshold exceeded.This pull request modifies two template files (dojo/templates/dojo/engagements_all.html and dojo/templates/dojo/product.html) that were flagged as sensitive codepath edits; review is recommended and sensitive paths/allowed authors can be configured in .dryrunsecurity.yaml.
🔴 Configured Codepaths Edit in
|
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
🔴 Configured Codepaths Edit in dojo/templates/dojo/product.html
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
We've notified @mtesauro.
All finding details can be found in the DryRun Security Dashboard.
Maffooch
approved these changes
Dec 22, 2025
blakeaowens
approved these changes
Dec 22, 2025
rossops
approved these changes
Dec 22, 2025
Maffooch
pushed a commit
to valentijnscholten/django-DefectDojo
that referenced
this pull request
Feb 16, 2026
…ding-metrics-mitigated-date metrics: use mitigated_date for closed findings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes using Cursor AI.
Fix: Closed Findings Metrics Use Mitigated Date Instead of Discovery Date
Fixes #9735
Problem
The "Closed Findings" metric in the Metrics dashboard incorrectly uses the finding's discovery date (
datefield) instead of its mitigated date (mitigatedfield) for filtering and grouping. This causes inaccurate reporting when filtering by date ranges that don't include the original discovery date.Solution
Updated metrics calculation logic to use the
mitigateddate field for closed findings:Impact
Closed findings metrics now accurately reflect when findings were actually closed/mitigated, rather than when they were discovered, providing more accurate reporting for security teams.