Skip to content

Remove Rules Framework and Google Sheets Integration#7889

Merged
cneill merged 7 commits into
DefectDojo:devfrom
Maffooch:sc-710
Mar 30, 2023
Merged

Remove Rules Framework and Google Sheets Integration#7889
cneill merged 7 commits into
DefectDojo:devfrom
Maffooch:sc-710

Conversation

@Maffooch
Copy link
Copy Markdown
Contributor

@Maffooch Maffooch commented Mar 27, 2023

Removing these features as they have been marked for removal for a long time
[sc-711]

@github-actions github-actions Bot added New Migration Adding a new migration file. Take care when merging. ui labels Mar 27, 2023
@Maffooch Maffooch closed this Mar 28, 2023
@Maffooch Maffooch reopened this Mar 28, 2023
Copy link
Copy Markdown
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cneill cneill merged commit 26cb8fe into DefectDojo:dev Mar 30, 2023
@damiencarol
Copy link
Copy Markdown
Contributor

Happy to see very old unmaintained feature be removed.

@Maffooch Maffooch deleted the sc-710 branch May 24, 2023 14:28
@marcnnn
Copy link
Copy Markdown

marcnnn commented Jun 22, 2023

Hello,

I was researching Knowledge Base Security report Management for a University seminar.
And found this project.
I was interested in how helpful a rule base System can be.
Do I interpret this PR correctly that the Rule Framework is removed?
It is still prominently promoted on the Project website?

Thanks,
Marc

@Maffooch
Copy link
Copy Markdown
Contributor Author

A rules based system would be incredibly helpful! However, the one that was implemented here was incredibly dangerous. There were practically no guard rails around the capabilities of the rules framework. It was initially hidden with deprecation methods, and then recently removed for users protection.

@mtesauro
Copy link
Copy Markdown
Contributor

@marcnnn +1 to what Cody said.

The rules framework, while powerful, allowed direct access to DefectDojo's internal objects and, if you weren't very knowledgeable about DefectDojo's internals, it was quite easy to corrupt your database into an unusable state.

I honestly forgot it was listed on that website and we can remove the reference from the website. we missed that when we removed the code portion of the rules framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

localization New Migration Adding a new migration file. Take care when merging. ui unittests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants