Add a "tag findings" parameter to the import-scan and reimport-scan API endpoints#8707
Conversation
| if apply_tags_to_findings: | ||
| item.tags.set(tags) |
There was a problem hiding this comment.
Is this needed here as well as the reimport_scan function? I think it would be best to remove this instance of adding the tags the findings
There was a problem hiding this comment.
I do think it is a good feature to have on re-imports. It provides users the opportunity to apply tags that either were not available or they missed during the initial import.
There was a problem hiding this comment.
Adding some clarification:
if apply_tags_to_findings:
item.tags.set(tags)
The above snippet of code is called in two places during the reimport scan process. Once in the process_parsed_findings and then second time in the reimport_scan function after the process_parsed_findings function has run.
Please remove the two lines of code attached to this comment under process_parsed_findings
|
It would also be nice to have this option in the UI to maintain parity between API and UI based imports |
UI work will be done as a separate PR so we can merge this one that is done.
Maffooch
left a comment
There was a problem hiding this comment.
Requesting changes as they were not for any UI work. @FelixHernandez please see the unresolved comment on my previous review. Pasting it here as well
Contextual Security AnalysisAs DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.
Chat with your AI-powered Security Buddy by typing Install and configure more repositories at DryRun Security |
Add a "tag findings" parameter to the import-scan and reimport-scan API endpoints
[sc-2329]
Description
This feature adds a new parameter to import-scan and reimport-scan API endpoints the new parameter is
apply_tags_to_findingsFalse as default.