add new parser xray#8852
Conversation
github-actions
Bot
added
settings_changes
|
I'm happy to see this parser. We bumped into the same missing piece so we wanted to propose our version of parser. But your is already covering more use cases. I will add some of our reports + unit tests. But, I'm not 100% sure about the parser's name. I fully understand that it is coming from the official name of the method, how to obtain the mentioned report. Just not sure. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
I am happy that it is of help to you. Regarding the name of the parser, it was taken from the official documentation but I accept suggestions. |
mtesauro
left a comment
mtesauro
left a comment
There was a problem hiding this comment.
Clean up 2 extra files in this PR and it will be good to go
There was a problem hiding this comment.
This file isn't part of the parser so please remove from this PR
There was a problem hiding this comment.
Same for this file.
Once these extra files are removed, I'm ready to approve this PR.
3 participants
From our organization we want to contribute with a new xray parser for https://jfrog.com/help/r/jfrog-cli/on-demand-binary-scan