Skip to content

Fix shellcheck#9147

Merged
mtesauro merged 2 commits into
DefectDojo:bugfixfrom
kiblik:fix_koalaman_shellcheck
Jan 19, 2024
Merged

Fix shellcheck#9147
mtesauro merged 2 commits into
DefectDojo:bugfixfrom
kiblik:fix_koalaman_shellcheck

Conversation

@kiblik
Copy link
Copy Markdown
Contributor

@kiblik kiblik commented Dec 11, 2023

Fix for #9119 (comment)

@dryrunsecurity
Copy link
Copy Markdown

dryrunsecurity Bot commented Dec 11, 2023

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status DryRun Security Check
AI-powered Sensitive Function Check
Configured Sensitive Files Check
AI-powered Sensitive Files Check

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

@kiblik kiblik marked this pull request as draft December 11, 2023 23:25
@kiblik
Copy link
Copy Markdown
Contributor Author

kiblik commented Dec 11, 2023

shellcheck is maybe fixed but opened couple of issues now

@kiblik kiblik force-pushed the fix_koalaman_shellcheck branch from b9f6aa8 to 95e053a Compare January 11, 2024 16:34
@github-actions github-actions Bot added New Migration Adding a new migration file. Take care when merging. settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR apiv2 docs unittests ui parser helm labels Jan 11, 2024
@kiblik kiblik force-pushed the fix_koalaman_shellcheck branch from 95e053a to 8ee6ad7 Compare January 11, 2024 16:37
@kiblik kiblik force-pushed the fix_koalaman_shellcheck branch from 8ee6ad7 to 3bbe6f3 Compare January 11, 2024 17:32
@kiblik kiblik marked this pull request as ready for review January 11, 2024 21:00
Copy link
Copy Markdown
Contributor

@cneill cneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but otherwise looks good. Thank you for tackling this! I should've done so when I first added the shellcheck job 😅

Comment thread docker/entrypoint-unit-tests-devDocker.sh Outdated
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@cneill cneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit 0444256 into DefectDojo:bugfix Jan 19, 2024
@kiblik kiblik deleted the fix_koalaman_shellcheck branch January 19, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apiv2 docker docs helm integration_tests New Migration Adding a new migration file. Take care when merging. parser settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR ui unittests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants