Skip to content

Changing name of WhiteSource to Mend#9359

Merged
Maffooch merged 11 commits into
DefectDojo:devfrom
grendel513:dev
Jan 31, 2024
Merged

Changing name of WhiteSource to Mend#9359
Maffooch merged 11 commits into
DefectDojo:devfrom
grendel513:dev

Conversation

@grendel513
Copy link
Copy Markdown
Contributor

@grendel513 grendel513 commented Jan 18, 2024

Updating name if WhiteSource to Mend - this does not touch documentation as there is another pull request for that specifically already.

@github-actions github-actions Bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR unittests parser labels Jan 18, 2024
@dryrunsecurity
Copy link
Copy Markdown

dryrunsecurity Bot commented Jan 18, 2024

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status DryRun Security Check
Sensitive Functions Analyzer
Configured Sensitive Files Check
Sensitive Files Analyzer

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

@cneill cneill changed the title Changing name of Whitestone to Mend Changing name of WhiteSource to Mend Jan 18, 2024
Copy link
Copy Markdown
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things:

  • unit test scan files that are not related to whitesource/mend should probably not be updated here
  • When changing the name of a test type, it is important to do the following as well:
    • update the test type object - this is to remove the possibility that a user attempts to import a test to whitesource and get a "parser not found" error
    • for any existing whitesource finding, the found_by column needs to be updated - this field is used to display all the test types that this finding belongs (multiple in cases of detected duplicates between tools)
    • Here is a migration that can be used as a reference

@Maffooch
Copy link
Copy Markdown
Contributor

Also would be good to add a breaking change section to the upgrade notes for folks that could be using Whitesource in an API based import. Here is an example from when the Nessus -> Tenable conversion was made

@github-actions github-actions Bot added the New Migration Adding a new migration file. Take care when merging. label Jan 19, 2024
@grendel513
Copy link
Copy Markdown
Contributor Author

Thanks @Maffooch - Migration has been added

@grendel513
Copy link
Copy Markdown
Contributor Author

Thanks @Maffooch - documentation added in upgrade notes

@grendel513
Copy link
Copy Markdown
Contributor Author

  • unit test scan files that are not related to whitesource/mend should probably not be updated here

I updated those references from whitesource to mend to better align with new name. functionality is not affected

@github-actions github-actions Bot added the docs label Jan 19, 2024
@@ -0,0 +1,16 @@
---
title: "Upgrading to DefectDojo Version 2.31.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the existing 2.31.md. This will create duplicity.

Copy link
Copy Markdown
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch
Copy link
Copy Markdown
Contributor

Failing test is accommodated in #9348

2024-01-31T19:46:48.0088609Z �[36muwsgi_1         |�[0m ======================================================================
2024-01-31T19:46:48.0089177Z �[36muwsgi_1         |�[0m FAIL: test_file_existence (unittests.test_parsers.TestParsers.test_file_existence) (parser='mend', category='docs')
2024-01-31T19:46:48.0089469Z �[36muwsgi_1         |�[0m ----------------------------------------------------------------------
2024-01-31T19:46:48.0089818Z �[36muwsgi_1         |�[0m Traceback (most recent call last):
2024-01-31T19:46:48.0090196Z �[36muwsgi_1         |�[0m   File "/app/unittests/test_parsers.py", line 27, in test_file_existence
2024-01-31T19:46:48.0090371Z �[36muwsgi_1         |�[0m     self.assertTrue(
2024-01-31T19:46:48.0091186Z �[36muwsgi_1         |�[0m AssertionError: False is not true : Documentation file '/app/unittests/../docs/content/en/integrations/parsers/file/mend.md' is missing or using 

@Maffooch Maffooch merged commit 1b579b0 into DefectDojo:dev Jan 31, 2024
@s13rr4-s3c
Copy link
Copy Markdown

In my tests the functionality is not working... also for Whitesource naming, Mend's json reports are not acceptable for defectdojo, even the json format.

The versions that i tested: defectdojo 3.31.0 && 2.27.4
Somebody else?

@kiblik
Copy link
Copy Markdown
Contributor

kiblik commented Feb 7, 2024

There was some issue with "WhiteSource vs Mend" reported in Slack as well https://owasp.slack.com/archives/C2P5BA8MN/p1707244117982809

@mtesauro
Copy link
Copy Markdown
Contributor

mtesauro commented Feb 7, 2024

@devopscodeck Can you provide a sanitized Mend json file? Having samples is really the only way for us to test scanner output especially for commercial offerings.

Happy to look at the parser code and add unit tests but we'll need an example first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs New Migration Adding a new migration file. Take care when merging. parser settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR unittests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants