Add "First Seen" Parser Flag#9361
Conversation
github-actions
Bot
added
settings_changes
Contextual Security AnalysisAs DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.
Chat with your AI-powered Security Buddy by typing Install and configure more repositories at DryRun Security |
| date = parser.parse(issue.get("created_date")) | ||
| else: | ||
| date = parser.parse(issue.get("created_date")) |
There was a problem hiding this comment.
They are the same, but this time it is intentional. In the unit test reports for this parser, there is not any available data in the report to satisfy the notion of a "last seen" date. Before this change, the created_date field was used, so it seemed appropriate to maintain that same behavior for both cases.
I am open to any suggestions that could make more sense though!
There was a problem hiding this comment.
In that case, is it necessary to replace the original implementation if there is no change in behavior?
| row.get("Issue opened: Scan date"), "%d %b %Y %H:%M%p %Z" | ||
| ) | ||
| else: | ||
| date = datetime.strptime( | ||
| row.get("Issue opened: Scan date"), "%d %b %Y %H:%M%p %Z" |
There was a problem hiding this comment.
They are the same, but this time it is intentional. In the unit test reports for this parser, there is not any available data in the report to satisfy the notion of a "last seen" date. Before this change, the Issue opened: Scan date field was used, so it seemed appropriate to maintain that same behavior for both cases.
I am open to any suggestions that could make more sense though!
There was a problem hiding this comment.
|
One more parser ;) Maffooch#2 |
|
Thanks @kiblik |
6 participants
Adds a "First Seen" parser flag to select parsers for users wanting the finding date to be reflected as the first time a vulnerability's detected rather then the last time
[sc-3965]