Skip to content

fix deduplication tooltip#9375

Closed
manuel-sommer wants to merge 3 commits into
DefectDojo:devfrom
manuel-sommer:fix_issue_7337
Closed

fix deduplication tooltip#9375
manuel-sommer wants to merge 3 commits into
DefectDojo:devfrom
manuel-sommer:fix_issue_7337

Conversation

@manuel-sommer
Copy link
Copy Markdown
Contributor

fix issue #7337

@dryrunsecurity
Copy link
Copy Markdown

dryrunsecurity Bot commented Jan 20, 2024

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status DryRun Security Check
AI-powered Sensitive Function Check
Configured Sensitive Files Check
Sensitive Files Analyzer

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

Copy link
Copy Markdown
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro
Copy link
Copy Markdown
Contributor

BTW, the tests about changing a model without creating a migration seems like a FP for this particular PR.

@manuel-sommer
Copy link
Copy Markdown
Contributor Author

BTW, the tests about changing a model without creating a migration seems like a FP for this particular PR.

There was a db mirgration generated. Shall I push it also eventhough it looks like a FP, but rather because django will create db migrations anyway?

@github-actions github-actions Bot added the New Migration Adding a new migration file. Take care when merging. label Jan 22, 2024
@manuel-sommer
Copy link
Copy Markdown
Contributor Author

Please first merge #9355
Then, the db migration is also right, based on the other PR.

@Maffooch
Copy link
Copy Markdown
Contributor

I am really struggling to figure out why the migration here is not being recognized. Even in the tests that pass, a new migration numbered 0199 is being generated:
image

@manuel-sommer
Copy link
Copy Markdown
Contributor Author

I have no clue

@manuel-sommer
Copy link
Copy Markdown
Contributor Author

I am really struggling to figure out why the migration here is not being recognized. Even in the tests that pass, a new migration numbered 0199 is being generated: image

@Maffooch shall I create another PR to verify the same behavior?

@mtesauro
Copy link
Copy Markdown
Contributor

I am really struggling to figure out why the migration here is not being recognized. Even in the tests that pass, a new migration numbered 0199 is being generated: image

@Maffooch shall I create another PR to verify the same behavior?

@manuel-sommer
TBH, I've had to do that in the past - sometimes is less work to just start over and repeat what you did in the broken PR in a new one. I say go for it.

@manuel-sommer
Copy link
Copy Markdown
Contributor Author

Take a look at #9454

@manuel-sommer manuel-sommer deleted the fix_issue_7337 branch January 31, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Migration Adding a new migration file. Take care when merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants