Skip to content

Bundler Audit Parser - Support for GHSA-Only Findings#9649

Merged
mtesauro merged 6 commits into
DefectDojo:devfrom
rh0dy:bundler-audit-support-for-ghsa
Mar 4, 2024
Merged

Bundler Audit Parser - Support for GHSA-Only Findings#9649
mtesauro merged 6 commits into
DefectDojo:devfrom
rh0dy:bundler-audit-support-for-ghsa

Conversation

@rh0dy
Copy link
Copy Markdown
Contributor

@rh0dy rh0dy commented Feb 29, 2024

Description

Results from a bundler audit scan can include findings that contain a GHSA ID but not a CVE ID (see here). I think these types of findings occur for a few reasons, i.e. the GHSA hasn't been assigned a CVE ID yet or that it never will be assigned a CVE ID.

Currently, the bundler audit parser doesn't support these types of findings, which feels like we may be missing out on importing valid vulnerabilities into DefectDojo.

This PR is to support parsing of bundler audit findings that may only contain a GHSA but not a CVE ID:

Pasted Graphic 9

Test results

./dc-unittest.sh --profile postgres-redis --test-case unittests.tools.test_bundler_audit_parser.TestBundlerAuditParser

...

test_get_findings (unittests.tools.test_bundler_audit_parser.TestBundlerAuditParser.test_get_findings) ... ok
test_get_findings_version9 (unittests.tools.test_bundler_audit_parser.TestBundlerAuditParser.test_get_findings_version9) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.009s

OK
Pre

Documentation

N/A.

@dryrunsecurity
Copy link
Copy Markdown

dryrunsecurity Bot commented Feb 29, 2024

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status DryRun Security Check
Sensitive Functions Analyzer
Configured Sensitive Files Analyzer
Sensitive Files Analyzer

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

@rh0dy rh0dy marked this pull request as ready for review February 29, 2024 00:56
Copy link
Copy Markdown
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Comment thread dojo/tools/bundler_audit/parser.py
Comment thread dojo/tools/bundler_audit/parser.py
Comment thread unittests/tools/test_bundler_audit_parser.py Outdated
Comment thread unittests/scans/bundler_audit/version_9.0.json Outdated
Comment thread dojo/tools/bundler_audit/parser.py
@mtesauro mtesauro merged commit ef07eb0 into DefectDojo:dev Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants