Skip to content

StringAgg: use default Value('')#9661

Merged
mtesauro merged 1 commit into
DefectDojo:devfrom
kiblik:set_StringAgg_default_none
Mar 4, 2024
Merged

StringAgg: use default Value('')#9661
mtesauro merged 1 commit into
DefectDojo:devfrom
kiblik:set_StringAgg_default_none

Conversation

@kiblik
Copy link
Copy Markdown
Contributor

@kiblik kiblik commented Mar 1, 2024

To avoid RemovedInDjango50Warning - In Django 5.0, StringAgg() will return None instead of an empty string if there are no rows. Pass default=None to opt into the new behavior and silence this warning or default=Value('') to keep the previous behavior.

Note: Discovered in #9503

@dryrunsecurity
Copy link
Copy Markdown

dryrunsecurity Bot commented Mar 1, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Sensitive Functions Analyzer 0 findings
Configured Sensitive Files Analyzer 1 findings
Sensitive Files Analyzer 0 findings

Note

🔴 Risk threshold exceeded. Adding a reviewer if one is configured in .dryrunsecurity.yaml.

notification list: @mtesauro @grendel513

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

@kiblik kiblik force-pushed the set_StringAgg_default_none branch from 40bbddb to ec35fbc Compare March 1, 2024 09:40
@kiblik kiblik changed the title StringAgg: use default None StringAgg: use default Value('') Mar 1, 2024
@kiblik kiblik marked this pull request as ready for review March 1, 2024 13:09
Copy link
Copy Markdown
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit c5741fc into DefectDojo:dev Mar 4, 2024
@kiblik kiblik deleted the set_StringAgg_default_none branch March 4, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants