`npm test` fails when opening archive

[noahtallen]

Update: This is caused by npm/cli#3405. npm pack outputs the filename in its info as @pakage/foo.tar.gz, but actually saves it as package/foo.tar.gz. As a result, when dts-critic does to open that tar.gz, it has the wrong filename, and the tests fail. This happens on newer npm versions, and can be worked around by using npm v6.

When running npm run test locally, I am getting the following error:

➜  DefinitelyTyped git:(update/wp-components-v17) npm run test wordpress__components 

> definitely-typed@0.0.3 test
> dtslint types "wordpress__components"

tar (child): @wordpress/components-17.0.0.tgz: Cannot open: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now

I get the same error whether I use @wordpress/components or wordpress__components. From what I can tell, the file is being saved, but without the leading @ symbol. For example:

➜  DefinitelyTyped git:(update/wp-components-v17) npm run test @wordpress/components

> definitely-typed@0.0.3 test
> dtslint types "@wordpress/components"

tar (child): @wordpress/components-17.0.0.tgz: Cannot open: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now
➜  DefinitelyTyped git:(update/wp-components-v17) ls word* 
wordpress-components-17.0.0.tgz

So it attempts to open @wordpress/components..., but the saved file is actually wordpress/components.... I poked around in dtslint, but I couldn't find anywhere it tries to run tar commands.

[peterblazejewicz]

@wordpress/components is a proper name to use here.

I think it should work, you've got some strange problem as your local setup tried to resolve this as external dependenc. This one is from Debian (WSL2):

➜  DefinitelyTyped git:(master) cd types/wordpress__components
➜  wordpress__components git:(master) ls
angle-picker-control   date-time           higher-order              placeholder         spinner
...
custom-select-control  form-toggle         package.json              slot-fill
dashicon               form-token-field    panel                     snackbar
➜  wordpress__components git:(master) npm i --no-package-lock

added 24 packages, and audited 25 packages in 6s

found 0 vulnerabilities
➜  wordpress__components git:(master) cd ../..
➜  DefinitelyTyped git:(master) npm test @wordpress/components

> definitely-typed@0.0.3 test
> dtslint types "@wordpress/components"

➜  DefinitelyTyped git:(master)

so the @ syntax should work, there is no special support for this, except of proper line in DTLint itself to handle namespaced packages (by a path translation):
https://github.com/microsoft/dtslint/blob/07fcc2634f9bd1a5b15f29092261ef5726b42170/src/index.ts#L63

[noahtallen]

Cool, I'll keep looking. Is it possible Linux is unsupported? I'll also try on macOS.

Running the same commands for me:

➜  DefinitelyTyped git:(update/wp-components-v17) ls
azure-pipelines.yml     README.es.md  README.ru.md
dangerfile.ts           README.it.md  README.zh.md
LICENSE                 README.ja.md  types
node_modules            README.ko.md  wordpress-components-17.0.0.tgz
notNeededPackages.json  README.md
package.json            README.pt.md
➜  DefinitelyTyped git:(update/wp-components-v17) cd types/wordpress__components
➜  wordpress__components git:(update/wp-components-v17) ls                            
angle-picker-control  custom-select-control  font-size-picker          menu-items-choice    radio-control       textarea-control
animate               dashicon               form-file-upload          modal                range-control       text-control
autocomplete          date-time              form-toggle               navigable-container  resizable-box       toggle-control
base-control          disabled               form-token-field          node_modules         responsive-wrapper  toolbar
button                draggable              higher-order              notice               sandbox             toolbar-button
button-group          dropdown               icon                      package.json         scroll-lock         tooltip
card                  dropdown-menu          icon-button               package-lock.json    select-control      tree-select
checkbox-control      drop-zone              index.d.ts                panel                shortcut            tsconfig.json
clipboard-button      external-link          isolated-event-container  placeholder          slot-fill           tslint.json
color-indicator       flex                   keyboard-shortcuts        popover              snackbar            wordpress__components-tests.tsx
color-palette         focal-point-picker     menu-group                primitives           spinner
color-picker          focusable-iframe       menu-item                 query-controls       tab-panel
➜  wordpress__components git:(update/wp-components-v17) npm i --no-package-lock

changed 1 package, and audited 25 packages in 2s

found 0 vulnerabilities
➜  wordpress__components git:(update/wp-components-v17) cd ..
➜  types git:(update/wp-components-v17) npm test @wordpress/components

> definitely-typed@0.0.3 test
> dtslint types "@wordpress/components"

tar (child): @wordpress/components-17.0.0.tgz: Cannot open: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now

[peterblazejewicz]

No, I don't think so Linux is unsupported. All CI actions are run on Ubuntu (same installs). I cannot use native *nix at the moment, by my WSL2 Ubuntu/Debian distros do not show this problem

➜ types git:(update/wp-components-v17) npm test @wordpress/components

this should be on parent/root of the repo:

➜ git:(update/wp-components-v17) npm test @wordpress/components

[noahtallen]

No, I don't think so Linux is unsupported

👍

this should be on parent/root of the repo:

Ah, that's my bad for the example. I get the same error from the root, though.

I do have a sparse checkout, so I could try cloning the whole thing. (I resolved all of the issues reported earlier in the test step though 🤔)

[noahtallen]

No, same error on master even after doing a full checkout and npm i for root and all packages which needed it. Maybe a permissions issue or an issue running it in a fork? (the fork is up to date)

[noahtallen]

I actually get a lot more error output on macOS, though this is still a sparse checkout:

~/source/DefinitelyTyped(master) » npm test @wordpress/components

> definitely-typed@0.0.3 test
> dtslint types "@wordpress/components"

tar: Error opening archive: Failed to open '@wordpress/components-14.0.0.tgz'
Error: /Users/noahtallen/source/DefinitelyTyped/types/wordpress__components/color-picker/index.d.ts:2:28
ERROR: 2:28     expect  TypeScript@4.5 compile error:
Cannot find module 'tinycolor2' or its corresponding type declarations.

/Users/noahtallen/source/DefinitelyTyped/types/wordpress__components/custom-select-control/index.d.ts:2:28
ERROR: 2:28     expect  TypeScript@4.5 compile error:
Cannot find module 'downshift' or its corresponding type declarations.

/Users/noahtallen/source/DefinitelyTyped/types/wordpress__components/higher-order/with-focus-outside/index.d.ts:1:27
ERROR: 1:27     expect  TypeScript@4.5 compile error:
Cannot find module '@wordpress/element' or its corresponding type declarations.

/Users/noahtallen/source/DefinitelyTyped/types/wordpress__components/resizable-box/index.d.ts:2:32
ERROR: 2:32     expect  TypeScript@4.5 compile error:
Cannot find module 're-resizable' or its corresponding type declarations.

/Users/noahtallen/source/DefinitelyTyped/types/wordpress__components/slot-fill/context.d.ts:1:27
ERROR: 1:27     expect  TypeScript@4.5 compile error:
Cannot find module '@wordpress/element' or its corresponding type declarations.

/Users/noahtallen/source/DefinitelyTyped/types/wordpress__components/wordpress__components-tests.tsx:2:27
ERROR: 2:27     expect  TypeScript@4.5 compile error:
Cannot find module '@wordpress/element' or its corresponding type declarations.
ERROR: 211:15   expect  TypeScript@4.5 compile error:
Parameter 'v' implicitly has an 'any' type.
ERROR: 1035:9   expect  TypeScript@4.5 compile error:
Argument of type 'typeof (Anonymous class)' is not assignable to parameter of type 'HFOComponent<any, any>'.
  Type '(Anonymous class)' is missing the following properties from type 'Component<any, any, any>': context, setState, forceUpdate, props, and 2 more.
ERROR: 1040:35  expect  TypeScript@4.5 compile error:
Property 'props' does not exist on type '(Anonymous class)'.
ERROR: 1051:31  expect  TypeScript@4.5 compile error:
Property 'props' does not exist on type 'PredefinedComponentClass'.
ERROR: 1054:65  expect  TypeScript@4.5 compile error:
Argument of type 'typeof PredefinedComponentClass' is not assignable to parameter of type 'HFOComponent<any, any>'.
  Type 'PredefinedComponentClass' is missing the following properties from type 'Component<any, any, any>': context, setState, forceUpdate, props, and 2 more.

    at /Users/noahtallen/source/DefinitelyTyped/node_modules/dtslint/bin/index.js:207:19
    at Generator.next (<anonymous>)
    at fulfilled (/Users/noahtallen/source/DefinitelyTyped/node_modules/dtslint/bin/index.js:6:58)

[noahtallen]

But after resolving those issues (npm i and adding the missing type/ directories), still getting the same error on mac:

~/source/DefinitelyTyped(master) » npm test @wordpress/components

> definitely-typed@0.0.3 test
> dtslint types "@wordpress/components"

tar: Error opening archive: Failed to open '@wordpress/components-14.0.0.tgz'

super weird!

[lobsterkatie]

I am getting similar errors on Mac OS:

Then when I npm install --save-dev webpack @types/webpack and try again:

(I ran this with yarn just out of habit, but I tried it with npm as well and got the same result.)

[peterblazejewicz]

I am getting similar errors on Mac OS:

this is different problem. When testing locally, there is no CI script that install all nested dependencies. One is expected to do this oneself. Here I would usually go to:

cd types/webapck
npm i --no-package-lock

and for any dependency for current test, that is required to be installed from some types/.../package.json
It seems to have no relation to a problem reported by OP initially

[noahtallen]

It seems to have no relation to a problem reported by OP initially

I agree -- while I did get those errors, after installing the nested dependencies, those errors go away and I'm left with the thing about tar.

[noahtallen]

I'm on another machine now, and I was really hoping it would start working, as I've set the repo up from scratch again!

Still getting this error:

$ npm test '@wordpress/data-controls'

> definitely-typed@0.0.3 test
> dtslint types "@wordpress/data-controls"

tar (child): @wordpress/data-controls-2.2.6.tgz: Cannot open: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now

[noahtallen]

It's creating a tar file and then trying to access it with the incorrect name:

~/source/DefinitelyTyped wp-data-controls-2.2.6
$ npm test @wordpress/data-controls

> definitely-typed@0.0.3 test
> dtslint types "@wordpress/data-controls"

tar (child): @wordpress/data-controls-2.2.6.tgz: Cannot open: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now

~/source/DefinitelyTyped wp-data-controls-2.2.6 6s
$ ls
azure-pipelines.yml  notNeededPackages.json  README.ja.md  README.ru.md
dangerfile.ts        package.json            README.ko.md  README.zh.md
LICENSE              README.es.md            README.md     types
node_modules         README.it.md            README.pt.md  wordpress-data-controls-2.2.6.tgz

[noahtallen]

I think I've narrowed it down to the npm-naming rule. It makes sense, as I assume that will try to match the types package name to the npm package name. Will keeping looking!

[noahtallen]

It happens somewhere inside of this function call: https://github.com/microsoft/dtslint/blob/8ec7ef4bce4122b911c5990b24241d86eef1464d/src/rules/npmNamingRule.ts#L180