Skip to content

d3-shape: CanvasPathMethods is now CanvasPath#27776

Closed
ghost wants to merge 1 commit into
masterfrom
d3-shape-canvaspath
Closed

d3-shape: CanvasPathMethods is now CanvasPath#27776
ghost wants to merge 1 commit into
masterfrom
d3-shape-canvaspath

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 1, 2018

A recent PR microsoft/TypeScript#25944 renamed CanvasPathMethods to CanvasPath.

@ghost ghost requested a review from borisyankov as a code owner August 1, 2018 19:06
@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Aug 1, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

@Andy-MS Thank you for submitting this PR!

🔔 @tomwanzek @gustavderdrache @borisyankov - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

@Andy-MS The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@denisname
Copy link
Copy Markdown
Contributor

Already looking for it in #27750.
I thought it was an unwanted breaking change: microsoft/TypeScript-DOM-lib-generator#548.

Could we just add a

/**
* @deprecated
*/
type CanvasPathMethods = CanvasPath;

in lib.dom.d.ts ?

@ghost ghost closed this Aug 1, 2018
@ghost ghost deleted the d3-shape-canvaspath branch August 1, 2018 19:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants