This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Avoid redundant pings#367
Merged
elibarzilay merged 2 commits intoMar 3, 2021
Merged
Conversation
Will make it easier to filter out owners who *have* approving reviews.
Shouldn't happen in general, but due to another bug it does. That should be fixed too, but it's still good to run a filter to be safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't ping people who have approving reviews
Shouldn't happen in general, but due to another bug it does. That
should be fixed too, but it's still good to run a filter to be safe.
(The bug will probably not get fixed if I manage to revise the workflow
according to #359.)