Ensure shields without toggles can still block damage#5697
Open
BarryNorfolk wants to merge 1 commit intoDeltaV-Station:masterfrom
Open
Ensure shields without toggles can still block damage#5697BarryNorfolk wants to merge 1 commit intoDeltaV-Station:masterfrom
BarryNorfolk wants to merge 1 commit intoDeltaV-Station:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
#5600 fixed deployable shields from blocking damage when they shouldn't, but inadvertently disabled shields without toggles from working.
Why / Balance
Blockable damage should be blocked when the user has an item that could block the blockable damage for the purpose of blocking. Causing the user wielding the blocking item to take less blockable damage than they would have not blocked in the case where they were not blocking by using a blocking item.
Technical details
Media
Bullet Shield
Energy Shield (Undeployed)
Energy Shield (Deployed)
Laser Shield
Telescopic Shield (Undeployed)
Telescopic Shield (Deployed)
Requirements
Licensing
Changelog
🆑