Replace Bionic Larynx Implant with Upstream one + Add Voice Mask back to Uplink#5702
Open
Cepelinas1 wants to merge 1 commit intoDeltaV-Station:masterfrom
Open
Replace Bionic Larynx Implant with Upstream one + Add Voice Mask back to Uplink#5702Cepelinas1 wants to merge 1 commit intoDeltaV-Station:masterfrom
Cepelinas1 wants to merge 1 commit intoDeltaV-Station:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Solving this issue, removing larynx voice implant, adding voice mask back and solving other bugs.
Why / Balance
Basically Upstream added a voice implant sometime ago, which they also removed the voice mask. So, seeing as we literally have two indentical voice mask implants, I figured we should stick to upstream version since that one is probably going to receive updates, while the other implant was originally intended for harpies, which got thrown in together with all other species.
The implant cost 2 TC, but has a chance to get a 50% discount.
Also changed the larynx implant to the wizden one in nukie and syndie recruiter.
Also also, it fixes a nanolink bug.
Technical details
Since voice mask got removed from upstream, I figured it doesn't really need the old comments? I put it in our _DV ftl file for the voice mask thing. You guys tell me how I should comment it.
Media
Requirements
Licensing
Changelog
🆑