-
Notifications
You must be signed in to change notification settings - Fork 9
Issue #1285 grid data from imod5 #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JoerivanEngelen
merged 10 commits into
issue_#1260_from_imod5_data_metaswap
from
issue_#1285_GridData_from_imod5
Nov 14, 2024
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
67051b0
Add empty method to base class
JoerivanEngelen bd263db
Implement first version of GridData.from_imod5_data
JoerivanEngelen a0761a0
remove unused arg
JoerivanEngelen 198af30
Refactor tests to reduce code duplication
JoerivanEngelen 0d9c0b1
Assign subunit coordinates
JoerivanEngelen 35542db
Add test_from_imod5_data
JoerivanEngelen 491d7ac
Format
JoerivanEngelen c33ef7b
Log instead of print
JoerivanEngelen 7256d13
Fix review comments
JoerivanEngelen 8d48522
Format
JoerivanEngelen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iMOD5 supports having two landuses per grid cell (so two "subunits" in iMOD Python lingo), the first one is for rural landuse, the second for urban landuse. The first one is specified by a rural landuse grid, and can thus have different values (e.g. agriculture, forestry, cattle), the second one is always landuse "urban", which is specified with the number 18.
I will explain some more in docstring.