Issue #1311 sprinkling from imod5 data#1312
Merged
JoerivanEngelen merged 20 commits intoDec 3, 2024
Merged
Conversation
…Sprinkling_from_imod5_data
…Sprinkling_from_imod5_data
… implemented) and from grids and explain in docstring
JoerivanEngelen
changed the base branch from
master
to
issue_#1260_from_imod5_data_metaswap
…Sprinkling_from_imod5_data
Manangka
approved these changes
Dec 3, 2024
|
Contributor
Author
|
For some reason the example CI breaks online, but it works locally. Merging, let's see if this persists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1311
Description
Adds the following:
imod.mf6.LayeredWell.from_imod5_cap_data, to construct LayeredWells for MODLOW6 from the CAP package in iMOD5 Data. Throws an error if data is provided as point data (IPF, which is read as pandas DataFrame). This has rate 0.0, actual rates will be inserted by in the coupling scheme of iMOD Coupler.imod.mf6.GroundwaterFlowModel.from_imod5_dataadds Sprinkling well if CAP package present. This does not affect MODFLOW6 model if not coupled to MetaSWAP: The wells have rates 0.0, so will not affect the simulation results.Sprinkling.from_imod5_datato construct a Sprinkling package from iMOD5 data.Checklist
Issue #nr, e.g.Issue #737