Issue #1858 Reading mete_grid.inp crashes on empty lines#1867
Merged
Conversation
…read of the produced file with inserted empty lines
JoerivanEngelen
requested changes
Jun 23, 2026
JoerivanEngelen
left a comment
JoerivanEngelen
left a comment
Contributor
There was a problem hiding this comment.
Thanks, I have two small suggestions!
Comment on lines
+54
to
+55
| potential_paths.append(cols[column_nr].replace('"', "")) | ||
| if _is_parsable_and_existing_path(potential_paths[-1], mete_grid_path): |
Contributor
There was a problem hiding this comment.
I think this improves readability:
Suggested change
| potential_paths.append(cols[column_nr].replace('"', "")) | |
| if _is_parsable_and_existing_path(potential_paths[-1], mete_grid_path): | |
| potential_path = cols[column_nr].replace('"', "") | |
| potential_paths.append(potential_paths) | |
| if _is_parsable_and_existing_path(potential_path, mete_grid_path): |
| potential_paths = [] | ||
| for line in lines: | ||
| cols = line.strip().split(",") | ||
| if len(cols) > column_nr: |
Contributor
There was a problem hiding this comment.
Could you add a comment why this check is necessary? Perhaps only do this when len(cols) == 0? Else throw error?
JoerivanEngelen
approved these changes
Jun 25, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included reading of the mete_grid.inp in the existing write test:
test_meteo_grid_write_read
Fixes #
Crash on empty line in mete_grid.inp file
Description
Checklist
Issue #nr, e.g.Issue #737pixi run generate-sbomand committed changes