Skip to content

fix(discover): use cbm_fopen for worktree gitlink + commondir reads #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeusData merged 1 commit into from
Jul 1, 2026
Merged

fix(discover): use cbm_fopen for worktree gitlink + commondir reads #750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/discover/discover.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,8 +778,9 @@ static bool resolve_git_common_dir(const char *repo_path, char *common_dir, size
return false;
}

/* Linked worktree: parse "gitdir: <path>" from the gitlink file. */
FILE *f = fopen(dot_git, "r");
/* Linked worktree: parse "gitdir: <path>" from the gitlink file.
* cbm_fopen (not raw fopen) so non-ASCII repo paths open on Windows. */
FILE *f = cbm_fopen(dot_git, "r");
if (!f) {
return false;
}
Expand Down Expand Up @@ -811,7 +812,7 @@ static bool resolve_git_common_dir(const char *repo_path, char *common_dir, size
* (typically a relative path like "../.."). Absent in single-worktree gitdirs. */
char commondir_path[CBM_SZ_4K];
path_join(commondir_path, sizeof(commondir_path), git_dir, "commondir");
FILE *cf = fopen(commondir_path, "r");
FILE *cf = cbm_fopen(commondir_path, "r");
if (cf) {
char cbuf[CBM_SZ_4K];
bool resolved = false;
Expand Down
Loading