update build to number#32
Merged
Merged
Conversation
squarepegg
approved these changes
Jan 17, 2022
ajwootto
reviewed
Jan 17, 2022
| private var country: String? = null | ||
| private var appVersion: String? = null | ||
| private var appBuild: String? = null | ||
| private var appBuild: Long? = null |
Contributor
There was a problem hiding this comment.
the SDK API spec is specified as a string also
- name: appBuild
in: query
description: App Build number of the running application
required: false
schema:
type: string
Contributor
Author
There was a problem hiding this comment.
This is version code, which is a number.
Version NAME will be a string.
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Tested out the before and after - appBuild is definitely giving a 400 when sent as a String!
Contributor
There was a problem hiding this comment.
@jonathannorris is this an expected change though?
jonathannorris
approved these changes
Jan 18, 2022
VicV
force-pushed
the
fix/api-conformity/DVC-1998
branch
from
18ace40 to
f9dbc7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.