Scheduler - Migrate popup resources and save/cancel tests to isolated environment#33786
Open
bit-byte0 wants to merge 2 commits into
Open
Scheduler - Migrate popup resources and save/cancel tests to isolated environment#33786bit-byte0 wants to merge 2 commits into
bit-byte0 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates several Scheduler Appointment Popup resource-related checks and save/cancel behavior tests from the integration suite into the isolated AppointmentPopup test environment, reducing reliance on full Scheduler integration for popup-specific behavior.
Changes:
- Added isolated-environment tests covering resource group structure, resource editor widget types, FontAwesome resource icons, and subject icon color updates.
- Moved save/cancel behavior assertions into isolated tests by validating
onSavecallback behavior for common and recurring appointments. - Extended the AppointmentPopup test factory to accept Scheduler-like
resourcesconfiguration and preload resource data when provided; removed the migrated tests (and now-unused types) from the integration suite.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts | Adds isolated AppointmentPopup tests for resources, icons, and save/cancel behavior. |
| packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.integration.test.ts | Removes resource and save/cancel tests that were migrated to the isolated suite and drops an unused type import. |
| packages/devextreme/js/__internal/scheduler/tests/mock/create_appointment_popup.ts | Extends the isolated popup factory to accept resources and preload them before showing the popup. |
Tucchhaa
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate 15 tests from integration to isolated
createAppointmentPopup()helper (Form + Popup only, no full Scheduler)How
Groups: Resources (6), Icons (2), Save/Cancel (7).
No production code changes, only test helper gets
resourcesoption.