AI Assistant: Add deselect option to selectByIndexes command#33790
Open
dmirgaev wants to merge 2 commits into
Open
AI Assistant: Add deselect option to selectByIndexes command#33790dmirgaev wants to merge 2 commits into
dmirgaev wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the grid AI Assistant’s selectByIndexes command to support deselecting rows (in addition to selecting them) by introducing a deselect boolean flag and wiring it through schema validation, execution logic, and public TypeScript types.
Changes:
- Added a
deselect: booleanargument to theselectByIndexespredefined command type definitions. - Updated
selectByIndexescommand implementation to calldeselectRows(via index→key resolution) whendeselectistrue. - Expanded Jest coverage for schema validation, deselect execution path, and default messages.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/ts/dx.all.d.ts | Updates aggregated public typings for selectByIndexes to include deselect. |
| packages/devextreme/js/common/grids.d.ts | Updates source public typings (PredefinedCommands) for selectByIndexes to include deselect. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/selection.ts | Extends the command schema and execution logic to support deselection; updates command description and default message. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/tests/selection.test.ts | Updates/extends unit tests to cover the new deselect flag behavior. |
dmirgaev
force-pushed
the
26_1__unselect_certain_row
branch
from
6a3280a to
3604110
Compare
|
|
||
| const selectByIndexesCommandSchema = z.object({ | ||
| indexes: z.array(z.number().int().min(1)).min(1), | ||
| deselect: z.boolean().optional(), |
Contributor
There was a problem hiding this comment.
use optionalNullish instead of optional - it allows null values and sanitize them on parse, which is necessary for proper work in strict mode
anna-shakhova
requested changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.