Skip to content

DataGrid - AI Assistant: toolbar & popup e2e tests#33803

Open
Alyar666 wants to merge 8 commits into
DevExpress:26_1from
Alyar666:ai_assistant_e2e_toolbar_popup_26_1
Open

DataGrid - AI Assistant: toolbar & popup e2e tests#33803
Alyar666 wants to merge 8 commits into
DevExpress:26_1from
Alyar666:ai_assistant_e2e_toolbar_popup_26_1

Conversation

@Alyar666
Copy link
Copy Markdown
Contributor

@Alyar666 Alyar666 commented Jun 2, 2026

No description provided.

Adds e2e TestCafe tests for the DataGrid AI Assistant toolbar button and popup lifecycle (plan §1.1, §1.10): button visibility, popup open, grid state preserved on close, custom title and toolbar keyboard a11y. Includes the shared testHelpers and AI Assistant POM accessors the suite depends on.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 2, 2026 22:27
@Alyar666 Alyar666 requested a review from a team as a code owner June 2, 2026 22:27
@Alyar666 Alyar666 self-assigned this Jun 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new TestCafe e2e coverage for the DataGrid AI Assistant entry points (toolbar button + popup lifecycle) and basic keyboard interaction, along with supporting page-object helpers in devextreme-testcafe-models.

Changes:

  • Added a new toolbarAndPopup.functional.ts suite validating toolbar button presence, popup opening/closing behavior, sort action application, and Enter-key activation.
  • Extended DataGrid and AI Assistant chat TestCafe models with additional API helpers/selectors (sort params accessor, focus helper, chat message/suggestion helpers).
  • Introduced shared AI Assistant TestCafe helpers for the AI integration container page URL and common ClientFunctions.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/testcafe-models/dataGrid/index.ts Adds DataGrid POM helpers for reading dataSource sort and programmatically focusing the AI Assistant toolbar button.
packages/testcafe-models/dataGrid/aiAssistantChat.ts Extends AI Assistant chat POM with input, message grouping, suggestions, disabled-state checks, and popup title accessor.
packages/testcafe-models/chat.ts Adds a getMessageBubbles() helper and refactors getMessage() to reuse it.
e2e/testcafe-devextreme/tests/dataGrid/common/aiAssistant/toolbarAndPopup.functional.ts New functional e2e tests for DataGrid AI Assistant toolbar + popup behavior and keyboard activation.
e2e/testcafe-devextreme/tests/dataGrid/common/aiAssistant/testHelpers.ts Shared constants and ClientFunctions for the AI integration test page and request/localization helpers.

Comment thread packages/testcafe-models/dataGrid/aiAssistantChat.ts Outdated
Comment thread packages/testcafe-models/dataGrid/aiAssistantChat.ts
Comment thread packages/testcafe-models/dataGrid/aiAssistantChat.ts Outdated
Alyar and others added 2 commits June 3, 2026 04:59
Fixes intermittent CI failures (`Cannot read properties of undefined (reading 'AIIntegration')`): the `dx.ai-integration.js` global can be defined a beat after navigation, so each `before` hook now awaits `aiIntegrationReady` before instantiating the mocked AIIntegration.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…elper

Replace the repeated 'await aiIntegrationReady() + createWidget' pattern in
before hooks with a single createWidgetWithAIIntegration helper.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 3, 2026 01:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comment thread packages/testcafe-models/dataGrid/aiAssistantChat.ts Outdated
Comment thread e2e/testcafe-devextreme/tests/dataGrid/common/aiAssistant/testHelpers.ts Outdated
Alyar and others added 2 commits June 3, 2026 17:59
…tors

- Anchor clear-chat button to dx-ai-chat__clear-button toolbar class
- Return nested .dx-button from getClearChatButton and check disabled directly
- Select confirm-dialog Yes button by position (locale-independent)
- Fix comment typo

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Deduplicate widget config into per-scenario option factories.
- 1.1.3: assert grid state is unchanged when the popup opens.
- 1.10.2: verify activation via both Enter and Space, with focus check.
- Remove redundant 1.10.1 click-open test (covered by 1.1.3 and 1.10.2).
- Drop AIAssistantChat POM helpers unused in this PR; add GridCore.apiState()
  and remove unused DataGrid.apiGetDataSourceSortParams().

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 3, 2026 17:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Comment thread packages/testcafe-models/gridCore/index.ts Outdated
Comment thread packages/testcafe-models/dataGrid/aiAssistantChat.ts
Copilot AI review requested due to automatic review settings June 3, 2026 20:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Comment thread e2e/testcafe-devextreme/tests/dataGrid/common/aiAssistant/testHelpers.ts Outdated
Comment thread packages/testcafe-models/dataGrid/aiAssistantChat.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants