Add missing swift build for linux ci#104
Merged
Merged
Conversation
DevYeom
reviewed
Oct 14, 2024
Owner
DevYeom
left a comment
DevYeom
left a comment
There was a problem hiding this comment.
Can you extend the timeout of StoreTests.test_lotsOfActions to 10 seconds to resolve the CI failure?
The time it takes may vary depending on the machine's performance. It seems that there may have been a change to the linux machine.
Contributor
Author
|
@DevYeom Seems like passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
OneWay is a swift library for state management regardless of platforms even if it is not contains apple enviroment. As Swift and Foundation became as an open source. Compilable and runnable on linux would get mattering. Thus validating build before merge can be very important
I personally had experienced swift-foundation's missing function which is not building on linux even working on macos. Moreover as introducing Concurrency, Foundation has got missing more and more refactored-async-concurrency methods. For in my case, Foundation missed URLSession's concurrency function.
As OneWay's main is concurrency, I think build-checking is crucial so I suggest swift build not only testing