Add Binder for swiftui#63
Closed
sobabear wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
I wrote none of annotation for documentation of usage, unless this function would be suitable. if it is ok, i will do with your opnion |
Owner
|
Thanks! When passing a binding, it is correct to directly call the store's TextField(
"TextField",
text: Binding(
get: { store.state.searchText },
set: { store.send(.setSearchText($0)) }
)
)The syntax sugar you suggested looks very nice. However, // In your own UI extension module or wrapping module
@_exported import OneWay |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues 💭
I want to make sugar for just setter value on State for ViewStore when i use SwiftUI. Thus I suggest binder using keypath to setter for oneway
Description 📝
Lets suppose i use simple textfield app
I marked two line which both prints out. And when i types like "Hello OneWay",
Problem Line1would be print" H", "He".... "Hello OneWay". However when i clicked, button which leads to Action.tapButtonForDebug prints out nothing but "" <- which is state.searchText.
So on this problem, i mostly used to handle this problem like adding Binder like
You know whenever it is getting more and more properties on State, this binder makes code much larger, thats why i open this PR.
Expected result would be better than above code.
Additional Notes 📚
Checklist ✅