Skip to content

Add effects result builder for sugar#68

Merged
DevYeom merged 1 commit into
DevYeom:mainfrom
sobabear:main
Jan 14, 2024
Merged

Add effects result builder for sugar#68
DevYeom merged 1 commit into
DevYeom:mainfrom
sobabear:main

Conversation

@sobabear
Copy link
Copy Markdown
Contributor

@sobabear sobabear commented Jan 8, 2024

Related Issues 💭

Add result builder for effects.

Description 📝

Added result builder for effects.merge and concat

can use like

//..

 return .concat(
  .increase,
  .increase,
  .increase
)
//.. can be like

 return .concat {
  .increase
  .increase
  .increase
}

Checklist ✅

  • If the changes affect existing functionality, please verify whether the above information has been appropriately described.

Copy link
Copy Markdown
Owner

@DevYeom DevYeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the good suggestion. 👍

I'm approving to give you credit. I will add the following three improvements afterwards.

  1. Public functions need comments for documentation.
  2. There is no test code for EffectsBuilder.
  3. It would be good if EffectsBuilder could support other cases of resultBuilder as well.

There is no need to delete the existing checklist items. A checklist is just a checklist.

@DevYeom DevYeom merged commit 6c2194e into DevYeom:main Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants