Skip to content

Fix clashing contexts#51

Merged
DominicOram merged 8 commits into
mainfrom
contexts
Oct 10, 2024
Merged

Fix clashing contexts#51
DominicOram merged 8 commits into
mainfrom
contexts

Conversation

@DominicOram

@DominicOram DominicOram commented Oct 4, 2024

Copy link
Copy Markdown
Contributor

See also the test in bluesky/ophyd-async#600

@DominicOram DominicOram requested a review from coretl October 4, 2024 15:22
@AlexanderWells-diamond

Copy link
Copy Markdown
Contributor

The CI failures here will be fixed by the changes that I'm working on in #50

Comment thread tests/test_aioca.py
@DominicOram DominicOram requested a review from coretl October 7, 2024 16:45
@DominicOram

Copy link
Copy Markdown
Contributor Author

Are you happy to merge despite the CI failures @coretl?

@coretl

coretl commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

@AlexanderWells-diamond how close are your CI updates? We can either merge and release this as is (possibly disabling tests to get it to publish), or wait for your updates?

@AlexanderWells-diamond

Copy link
Copy Markdown
Contributor

I'm working on a full adoption of the Copier template, which will involve things like moving the source files around. See #52 which replaced #50.

@codecov

codecov Bot commented Oct 10, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.33%. Comparing base (8a28070) to head (02a527d).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/aioca/_catools.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #51      +/-   ##
===========================================
- Coverage   100.00%   99.33%   -0.67%     
===========================================
  Files            4        4              
  Lines          446      453       +7     
===========================================
+ Hits           446      450       +4     
- Misses           0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominicOram

Copy link
Copy Markdown
Contributor Author

Discussed with @coretl, he's happy to merge without full coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants